[Webkit-unassigned] [Bug 58346] Convert media controls hooks to a client interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58346


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89900|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #7 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-04-15 19:48:29 PST ---
(From update of attachment 89900)
View in context: https://bugs.webkit.org/attachment.cgi?id=89900&action=review

> Source/WebCore/html/shadow/MediaControlClient.h:38
> +class MediaControlClient : public HTMLDivElement {

This is interesting. If it's a subclass of an HTMLDivElement, it's probably not a client. I was imagining MediaControlClient to not be a subclass of anything, but maybe that would be too convoluted.

I think what you have is fine, but you need to get rid of the Client designation. This is a base class, and the convention in WebKit is to use a Base suffix. So this would be an HTMLMediaControlBase.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.