[Webkit-unassigned] [Bug 58591] RenderDetailsMarker should belong to shadow element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58591


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89850|review?                     |review+
               Flag|                            |




--- Comment #12 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-04-15 14:18:49 PST ---
(From update of attachment 89850)
View in context: https://bugs.webkit.org/attachment.cgi?id=89850&action=review

Ok with nits.

> Source/WebCore/ChangeLog:10
> +          Note thtat marker size is given via style for -webkit-details-marker pseudo class.

thtat -> that

> Source/WebCore/html/HTMLDetailsElement.cpp:93
> +    if (oldSummary && oldSummary->parentNodeForRenderingAndStyle()) {
> +        oldSummary->detach();
> +        oldSummary->attach();
> +    }
> +        
> +    if (refreshRenderer == RefreshRendererAllowed) {
> +        m_mainSummary->detach();
> +        m_mainSummary->attach();
> +    }

I cringe seeing this code, but I think we can tackle this later.

> Source/WebCore/html/HTMLDetailsElement.cpp:145
> +    setAttribute(openAttr, m_isOpen ? String() : String(""));

use nullAtom and emptyAtom

> Source/WebCore/html/HTMLSummaryElement.cpp:56
> +    // Since HTMLDetailsElement::mainSummary() is possibly not ready at this time, we should make attach() lazy.

We should always attach lazily. No need for this comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.