[Webkit-unassigned] [Bug 58505] [Chromium]UI polishes and tweaks to Autofill dropdown menu.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58505





--- Comment #18 from Naoki Takano <takano.naoki at gmail.com>  2011-04-15 11:46:21 PST ---
After looking around the source code, I notice itemIsSeparator() might return true even if not AutoFillPopupMenuClient. So it implies other popup window separator might be drawn.

Ok, I add one more parameter to PopupMenuStyle and drag it.

(In reply to comment #13)
> Ilya,
> 
> Thank you for your great comments every time.
> 
> (In reply to comment #12)
> > > Source/WebCore/platform/chromium/PopupMenuChromium.cpp:954
> > > +        gc->fillRect(separatorRect, Color::lightGray, ColorSpaceDeviceRGB);
> > 
> > Is it possible for a <select> popup to have a separator?  If so, again, I think we only want this change for the Autofill popup.  (I'm not 100% sure about that though.)
> Hmm... I'm also not sure we will have separator for other popup windows. At least, we don't have any separator tag for select html tag though. We also can drag the padding value with PopupMenuStyle. But the class is getting bigger...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.