[Webkit-unassigned] [Bug 52952] Focus ring for anchor with inline image is incorrect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52952





--- Comment #34 from Eric Seidel <eric at webkit.org>  2011-04-15 09:53:55 PST ---
(From update of attachment 89225)
View in context: https://bugs.webkit.org/attachment.cgi?id=89225&action=review

This looks reasonable to me, but I think we should rope hyatt or mitz in here still.  Lets see if we can find one of them in #webkit today.

> Source/WebCore/rendering/InlineFlowBox.cpp:109
> +    } else {
> +        m_hasTextChildrenOnly = false;
>      }

Style nit:  no { } on single line blocks.  I'm surprised the style queue didn't flag this.

> Source/WebCore/rendering/InlineFlowBox.h:293
> +    bool m_hasTextChildrenOnly : 1;

I probably would have named this m_hasOnlyTextChildren.

So this is only children?  Or is this true of all dependents?  Do we keep this up to date when grafting on sub-trees?  I'm not sure what linebox tree manipulations are allowed that we'd need to worry about.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.