[Webkit-unassigned] [Bug 58064] Web Inspector: Network events don't preserves, when inspector frontend closed and open again

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58064





--- Comment #26 from Sergey Vorobyev <sergeyvorobyev at google.com>  2011-04-15 07:03:06 PST ---
(From update of attachment 89774)
View in context: https://bugs.webkit.org/attachment.cgi?id=89774&action=review

>> Source/WebCore/ChangeLog:8
>> +
> 
> Please provide a brief description of the changes made.

done.

>> Source/WebCore/ChangeLog:9
>> +        No new tests. (OOPS!)
> 
> You will not be able to commit a patch with this line.

done.

>>> Source/WebCore/inspector/InspectorResourceAgent.cpp:94
>>> +    if (backgoundEventsCoollectionEnabled()) {
>> 
>> The method name has two mistypes, please fix.
> 
> I think that when event collection is enabled you could simply set inspectorFrotnedChannel to the proxy object and clear it in clearFrontend. In fact you can completely ignore passed frontend object.
> 
> If you proceed with the current approach, you should reset the agent and frontend states as they were before setFrontend including setting m_frontend to m_mockFrontend.get

@apavlov done, thank you

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.