[Webkit-unassigned] [Bug 58064] Web Inspector: Network events don't preserves, when inspector frontend closed and open again

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58064


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89579|review?                     |review-
               Flag|                            |




--- Comment #19 from Yury Semikhatsky <yurys at chromium.org>  2011-04-15 05:36:59 PST ---
(From update of attachment 89579)
View in context: https://bugs.webkit.org/attachment.cgi?id=89579&action=review

> Source/WebCore/inspector/InspectorResourceAgent.cpp:94
> +    if (enabledBackgoundEventsCoollection()) {

enabledBackgoundEventsCoollection -> backgoundEventsCoollectionEnabled

> Source/WebCore/inspector/InspectorResourceAgent.cpp:-281
> -    ASSERT(!m_instrumentingAgents->inspectorResourceAgent());

This assert should be preserved if it fails you should figure out when to clear pointer to this agent from the instrumenting agents structure.

> Source/WebCore/inspector/InspectorResourceAgent.cpp:504
> +    // TODO(vors):

Please file a bug on this and add FIXME(bug number) instead of the TODO.

> Source/WebCore/inspector/InspectorResourceAgent.h:134
> +    OwnPtr<InspectorFrontend::Network> m_frontend;

This is wrong since the frontend passed in setFrontend method is owned by the caller, r- for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.