[Webkit-unassigned] [Bug 58649] Web Inspector: refactor resource setContent / revisions infrastructure to get rid of onRevert callback.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 15 05:24:41 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58649





--- Comment #6 from Alexander Pavlov (apavlov) <apavlov at chromium.org>  2011-04-15 05:24:41 PST ---
(From update of attachment 89770)
View in context: https://bugs.webkit.org/attachment.cgi?id=89770&action=review

> Source/WebCore/inspector/front-end/CSSStyleModel.js:179
> +            this.dispatchEventToListeners(WebInspector.CSSStyleModel.Events.StyleSheetChanged, {styleSheetId:styleSheetId, content:content, majorChange:majorChange});

A common object notation across Web Inspector is: { prop1: prop1Val, prop2: prop2Val }

> Source/WebCore/inspector/front-end/CSSStyleModel.js:643
> +                userCallback("No stylesheet found");

A good idea is to include the url into the message. We also can refine the message saying that the stylesheet is not accessible from DOM (since this stylesheet can be linked as "stylesheet alternate" and still be non-accessible).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list