[Webkit-unassigned] [Bug 58649] Web Inspector: refactor resource setContent / revisions infrastructure to get rid of onRevert callback.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58649





--- Comment #2 from Pavel Podivilov <podivilov at chromium.org>  2011-04-15 03:39:40 PST ---
(From update of attachment 89757)
View in context: https://bugs.webkit.org/attachment.cgi?id=89757&action=review

> Source/WebCore/inspector/front-end/CSSStyleModel.js:633
> +    _innerSetContent: function(url, content, majorChange, userCallback, error)

Do we really need the "error" argument here? It looks confusing.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:150
> +                this._updateBreakpointsAfterLiveEdit(sourceFile.id, oldSource, newSource);

This should only be called when content is changed via "revert to this revision". When editing script in scripts panel breakpoints are moved accurately by editor, and we don't want to move them again here.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:155
> +                sourceFile.reload();

Why this changed? Errors during live edit should not lead to source frame reload.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.