[Webkit-unassigned] [Bug 58505] [Chromium]UI polishes and tweaks to Autofill dropdown menu.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58505





--- Comment #11 from Ilya Sherman <isherman at chromium.org>  2011-04-14 23:41:09 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 89517 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=89517&action=review
> > 
> > I know that a lot of the code in this file is shared by the <select> popup (except on Mac) and by the Autofill popup.  I believe we only want these changes to affect the Autofill popup.  Have you verified that this is indeed the case?
> I verified them, but I assumed the other popups also need to obey this rule. I'll leave the other popups as it is.
> 
> My plan is
> 1, Add whole padding and margin information into PopupMenuStyle.
> 2, Add popup window type into PopupMenuStyle and according to the type, change the margin.
> 
> I prefer to 1.

Long-term, we want to more cleanly separate the Autofill popup code from the <select> popup code -- the current dual-purpose code can be a bit clumsy to update.  I agree that (1) is probably a better short term solution that (2) though -- perhaps some WebKit folks more familiar with this code could comment?

> As Roma isn't worried about it, so I will leave here.

Ok :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.