[Webkit-unassigned] [Bug 58576] Evaluate PLATFORM(GTK) before OS(WINDOWS)

Thu Apr 14 21:43:42 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=58576

--- Comment #3 from Fridrich Strba <fridrich.strba at bluewin.ch>  2011-04-14 21:43:42 PST ---
(In reply to comment #2)
> (From update of attachment 89656 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89656&action=review
> 
> > Source/WebCore/platform/FileSystem.h:-80
> > -#if OS(WINDOWS)
> 
> It might be better here to simply change this to #if OS(WINDOWS) && !PLATFORM(GTK)

In my opinion, moving the 3 lines is producing more readable code and correspond to what for instance QT port does, the evaluation of its platform comes before the windows evaluation. There is already enough of forest of ifdefs so that the stuff be even more offuscated :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.