[Webkit-unassigned] [Bug 58399] Web Inspector: Timeline is too narrow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58399


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89681|review?                     |review+
               Flag|                            |




--- Comment #9 from Pavel Feldman <pfeldman at chromium.org>  2011-04-14 21:20:00 PST ---
(From update of attachment 89681)
View in context: https://bugs.webkit.org/attachment.cgi?id=89681&action=review

This looks good, thanks for doing it.

> Source/WebCore/ChangeLog:5
> +        Changed Network Panel widths so that Timeline is 50%.

It should be:

WebInspector: Title
http://...
<optional blank line>
Multiline description here.

Changes digest.

> Source/WebCore/inspector/front-end/NetworkPanel.js:960
> +            widths.timeline = 50;

It leaves 5% left, is that intentional? Did you check whether column resize bars are aligned properly?

> Source/WebCore/inspector/front-end/NetworkPanel.js:1436
> +    _setTextAndTitle: function(element, text)

You could define setTextAndTitle on Elements' prototype in the utilities.js.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.