[Webkit-unassigned] [Bug 58448] [Qt] Implement initial support to DataTransferItems

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58448





--- Comment #4 from Andreas Kling <kling at webkit.org>  2011-04-14 14:35:47 PST ---
(From update of attachment 89640)
View in context: https://bugs.webkit.org/attachment.cgi?id=89640&action=review

Interesting stuff. :)

There seems to be a lot of code duplication in the DataTransferItemsQt implementation, maybe we could share the common paths with DataTransferItemsChromium somehow? On a related note, when adding derived code like this, you should leave the original copyright (as well as adding your own if applicable.)

> Source/WebCore/bindings/js/JSDataTransferItemsCustom.cpp:14
> +bool JSDataTransferItems::deleteProperty(ExecState *exec, const Identifier& propertyName)
> +{
> +    return Base::deleteProperty(exec, propertyName);
> +}

This should be avoidable using a conditional in the IDL file. Though what does Chromium do in their custom deleteProperty?

> Source/WebCore/platform/qt/ClipboardQt.cpp:369
> +    RefPtr<DataTransferItemsQt> items = DataTransferItemsQt::create(this, m_frame->document()->scriptExecutionContext());

m_frame->document() is guaranteed to be non-null here?

> Source/WebCore/platform/qt/ClipboardQt.h:90
> +    Frame *m_frame;

Coding style, Frame* m_frame;

> Source/WebCore/platform/qt/DataTransferItemQt.cpp:29
> +#include <QtCore/QDebug>

Remove.

> Source/WebCore/platform/qt/DataTransferItemQt.cpp:104
> +    }

What about other MIME types?

> Source/WebCore/platform/qt/DataTransferItemsQt.cpp:29
> +#include <QtCore/QDebug>

Remove.

> Source/WebCore/platform/qt/DataTransferItemsQt.cpp:55
> +    qDebug() << m_items.size();

Remove.

> Source/WebCore/platform/qt/DataTransferItemsQt.h:55
> +    friend class ClipboardQt;

Unnecessary friend declaration.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.