[Webkit-unassigned] [Bug 58509] Add a sample test case for GTest framework

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58509


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89523|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from David Levin <levin at chromium.org>  2011-04-14 13:27:10 PST ---
(From update of attachment 89523)
View in context: https://bugs.webkit.org/attachment.cgi?id=89523&action=review

Just a few suggestions.

> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:3435
> +			buildSettings = {

Let's try to trim this down.

> Source/JavaScriptCore/wtf/tests/RunAllWtfTests.cpp:35
> +int main(int argc, char **argv) {

The { needs to be on the next line.

> Source/JavaScriptCore/wtf/tests/RunAllWtfTests.cpp:36
> +    std::cout << "Running main() from gtest_main.cc\n";

Avoid stream io for consistency for the rest of WebKit.

> Source/JavaScriptCore/wtf/tests/StringTests.cpp:41
> +TEST_F(CStringTest, TestLength) {

{ on next line.

> Source/ThirdParty/gtest/xcode/gtest.xcodeproj/project.pbxproj:581
> +			developmentRegion = English;

Remove this to keep us the same as upstream.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.