[Webkit-unassigned] [Bug 58535] REGRESSION (r83820): Lots of compositing tests failing on Windows 7 Release (Tests)

Thu Apr 14 13:10:39 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=58535

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89630|review-                     |review+
               Flag|                            |

--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-04-14 13:10:39 PST ---
(From update of attachment 89630)
View in context: https://bugs.webkit.org/attachment.cgi?id=89630&action=review

>>> Source/WebCore/rendering/RenderLayerBacking.cpp:571
>>>  #endif
>> 
>> Now I wonder if these aren't all backwards. You want scrollbars layers in Chromium. Mac/Windows _only_ wants them if there are overlay scrollbars. So I think the logic is wrong.
> 
> On chromium this function returns true iff there is a horizontal scrollbar.  On non-chromium this function returns true iff the page is using overlay scrollbars _and_ there is a horizontal scrollbar.  Maybe there are too many negations here to be clear?

I was confused by the early return. So this is OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.