[Webkit-unassigned] [Bug 58294] continue (3rd) experiment with moving caret by word in visual order

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58294





--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org>  2011-04-14 12:20:46 PST ---
(From update of attachment 89513)
View in context: https://bugs.webkit.org/attachment.cgi?id=89513&action=review

>> Source/WebCore/editing/visible_units.cpp:1277
>> +  
> 
> it is set as "true" at line 1289. And we need this flag to avoid search word breaks in the box in dead-loop. Please note: last == true does not necessarily mean the last word break returned is null visible position.

Ah, ok.

> Source/WebCore/editing/visible_units.cpp:1386
> +        if (offset == invalidOffset || orderedWordBoundaries[orderedWordBoundaries.size() - 1].offsetInInlineBox != offset)

It seems like it's redundant to check against invalidOffset since offsetInInlineBox should never be invalidOffset.

> Source/WebCore/editing/visible_units.cpp:1442
> +        } else 
> +            wordBreak = visuallyLastWordBoundaryInBox(adjacentBox, adjacentBox == box ? offset : invalidOffset, blockDirection);            

If visuallyLastWordBoundaryInBox really returns the visually last word boundary in box, then why is this correct?  Why should we be returning the visually last word boundary when the block's direction is RTL?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.