[Webkit-unassigned] [Bug 58557] Extract layoutRepacedElements from layoutInlineChildren

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58557





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2011-04-14 12:03:58 PST ---
(From update of attachment 89612)
View in context: https://bugs.webkit.org/attachment.cgi?id=89612&action=review

>> Source/WebCore/ChangeLog:8
>> +        Extracted a block of code in layoutInlineChildren as layoutRepacedElements.
> 
> layoutRepacedElements => layoutReplacedElements
> 
> (you used layoutRepacedElements throughout this patch)
> 
> And, as Eric Seidel remarked, this function seems to more than just handle replace elements.

Oops. I'll rename the function.  Any suggestion?

>> Source/WebCore/rendering/RenderBlockLineLayout.cpp:740
>> +        } else if (object->isText() || (object->isRenderInline() && !endOfInline)) {
> 
> Nit: The parentheses around the second disjunct are unnecessary since && (logical and) has higher precedence than || (logical or).

There's at least one port where not having this parenthesis causes a build failure because new versions of gcc gives you a warning on this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.