[Webkit-unassigned] [Bug 47320] [Performance] Only call sendContentResizeNotification when the scrollbar actually did change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 06:54:11 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=47320





--- Comment #20 from Ryuan Choi <ryuan.choi at samsung.com>  2011-04-14 06:54:10 PST ---
(In reply to comment #18)
> (From update of attachment 78365 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78365&action=review
> 
> > Source/WebCore/platform/ScrollView.cpp:89
> > +    ASSERT(!(hasBar && avoidScrollbarCreation()));
> 
> I don't understand why the "hasBar && avoidScrollbarCreation()" test no longer returns.  You assert if this case is true -- do you want to execute the code under this condition?
> 
> > Source/WebCore/platform/ScrollView.cpp:105
> > +    ASSERT(!(hasBar && avoidScrollbarCreation()));
> 
> Ditto

Sorry about late answer.

This patch is old and I can't assure any side effects.
So I simplified my patch to explain what I really want.
It will be fine, but check hasBar && avoidScrollbarCreation two times.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list