[Webkit-unassigned] [Bug 58447] Web Inspector: ResourceResponse should have encodedDataLength field for synchronous requests transfer size

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 14 05:12:44 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58447


Vsevolod Vlasov <vsevik at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89386|0                           |1
        is obsolete|                            |
  Attachment #89386|commit-queue?               |
               Flag|                            |
  Attachment #89558|                            |review?, commit-queue?
               Flag|                            |




--- Comment #3 from Vsevolod Vlasov <vsevik at chromium.org>  2011-04-14 05:12:43 PST ---
Created an attachment (id=89558)
 --> (https://bugs.webkit.org/attachment.cgi?id=89558&action=review)
Patch

(In reply to comment #2)
> (From update of attachment 89386 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89386&action=review
> 
> > Source/WebCore/loader/FrameLoader.cpp:2829
> > +    notifier()->sendRemainingDelegateMessages(m_documentLoader.get(), identifier, response, data.size(), static_cast<int>(response.encodedDataLength()), error);
> 
> what are the implications of this change?
This parameter was introduced by my previous change and the value passed here was not correct. Now we are passing a correct value that will be forwarded to didReceiveData.

> > Source/WebCore/platform/network/ResourceResponseBase.h:68
> > +    long long encodedDataLength() const;
> 
> This should be a part of ResourceLoadInfo.
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list