[Webkit-unassigned] [Bug 52988] REGRESSION (r75555): Safari RSS sidebar jiggles when scrolling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52988





--- Comment #29 from Andy Estes <aestes at apple.com>  2011-04-14 01:18:44 PST ---
(In reply to comment #27)
> (From update of attachment 89544 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89544&action=review
> 
> > Source/WebCore/dom/EventQueue.cpp:43
> > +    return applicationIsSafari() && (document->url().protocolIs("feed") || document->url().protocolIs("feeds"));
> 
> Maybe this would make more sense as a preference setting, then it could be customized per view. That would be a cleaner way to do the check, I think, and it would avoid the problem in applicationIsSafari cited below.

It looks like Safari RSS doesn't get its own view; the current view is navigated to the RSS page. This means that a Setting flag would have to be toggled on and off per navigation based on the URL scheme, which seems more difficult than the current approach.

> 
> > Source/WebCore/platform/RuntimeApplicationChecks.cpp:58
> > +    static bool isSafari = mainBundleIsEqualTo("com.apple.Safari") || mainBundleIsEqualTo("com.apple.WebProcess");
> 
> This should have a FIXME, because long-term, WebProcess will not be used only by Safari. Or perhaps there is a better way to check specifically for Safari's WebProcess, in which case maybe it would be wise to future-proof this now.

I'd be happy to do this, although I'm not sure I know precisely how to check if it's Safari's WebProcess, at least not via CF API.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.