[Webkit-unassigned] [Bug 58456] Expose factory function for creating FileEntry and DirectoryEntry instances from Chromium side

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 13 17:33:00 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58456





--- Comment #9 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-04-13 17:33:00 PST ---
Attachment 89502 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit/chromium/public/WebFrame.h:268:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/public/WebFrame.h:272:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/fileapi/EntryBase.cpp:68:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebKit/chromium/src/WebFrameImpl.h:112:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/chromium/src/WebFrameImpl.h:115:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 5 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list