[Webkit-unassigned] [Bug 57891] Rebaseline queue server

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57891





--- Comment #8 from Mihai Parparita <mihaip at chromium.org>  2011-04-13 15:50:45 PST ---
(From update of attachment 89462)
View in context: https://bugs.webkit.org/attachment.cgi?id=89462&action=review

>> Tools/RebaselineQueueServer/handlers/builderqueue.py:66
>> +            if test not in current_tests:
> 
> Isn't this just a set intersection?

Difference, but yes. Changed.

>> Tools/RebaselineQueueServer/handlers/builderqueue.py:69
>> +        self.redirect('/builder/%s/queue' % builder_name)
> 
> You might want something to generate these URLs.

Added _queue_list_url to QueueHandler.

>> Tools/RebaselineQueueServer/handlers/pages.py:37
>> +        builder_names = QueueEntry.get_builder_names()
> 
> get_ isn't really webkit style.

Renamed to builder_names (and get_for_builder_name to entries_for_builder).

>> Tools/RebaselineQueueServer/main.py:31
>> +use_library('django', '1.2')
> 
> I thought it was possible to do this in app.yaml these days.  But I may be wrong.

http://code.google.com/appengine/docs/python/tools/libraries.html#Django only mentions doing it from main.py.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.