[Webkit-unassigned] [Bug 58073] Presence of shadow DOM should suppress rendering of ordinary child nodes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58073


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89466|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Ojan Vafai <ojan at chromium.org>  2011-04-13 15:02:28 PST ---
(From update of attachment 89466)
View in context: https://bugs.webkit.org/attachment.cgi?id=89466&action=review

> Source/WebCore/dom/Node.cpp:855
> +inline static ContainerNode* shadowRoot(Node* node)

I don't think this inline is really needed. We should reserve inline for cases where we can actually show an improvement, no? But I'm a n00b so feel free to ignore this. :)

> Source/WebCore/dom/Node.cpp:1460
> +inline static bool shouldCreateRendererFor(Node* node, ContainerNode* parentForRenderingAndStyle)

ditto re: inline

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.