[Webkit-unassigned] [Bug 57090] Simplifying Worker termination sequence (removing unnecessary mutex)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 13 14:34:09 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=57090





--- Comment #14 from Dmitry Titov <dimich at chromium.org>  2011-04-13 14:34:09 PST ---
I didn't land this patch because it exposed a race condition in fast/workers/shared-worker-frame-lifecycle.html that caused it to occasionally fail when run like this:
run-webkit-tests LayoutTests/fast/workers/ --iterations 100 --random

The culprit happens to be document.write(), called mostly directly from inline script (in this case it appends to the document) and sometimes deferred via setTimeout() (when not all worker threads from previous test happen to exit yet) - in latter case it overwrites the whole document and makes the test fail.

Added the change from document.write() to using appendChild(), verified we don't use document.write in other places in worker tests.

Updated patch is coming.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list