[Webkit-unassigned] [Bug 53645] [GTK] editing/pasteboard/copy-standalone-image.html fails
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 13 11:47:36 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=53645
--- Comment #6 from Martin Robinson <mrobinson at webkit.org> 2011-04-13 11:47:36 PST ---
(In reply to comment #2)
> (From update of attachment 81157 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81157&action=review
Thank you both for your comments!
> > Source/WebCore/platform/gtk/PasteboardGtk.cpp:115
> > + // FIXME: Later this code should be shared with Chromium somehow. Chances are all platforms want it.
> Which code? Can we abstract said code into a helper method (even if we don't share it now)?
I've abstracted this code into a helper.
> > Source/WebCore/platform/gtk/PasteboardGtk.cpp:130
> > + if (!url.isEmpty()) {
> eric: This whole block feels like a helper method to me. :)
> rniwa: Indeed, it seems like we can add a function to markup.h/cpp.
I've abstracted this into a helper based on a version of this code in the chromium platform directory. I've also replaced another implementation of it in the win platform directory.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list