[Webkit-unassigned] [Bug 58459] Exclude webkitGetUserMedia from the navigator-detached-no-crash test

Wed Apr 13 11:41:46 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=58459

Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89412|review?                     |review-
               Flag|                            |

--- Comment #5 from Jian Li <jianli at chromium.org>  2011-04-13 11:41:46 PST ---
(From update of attachment 89412)
View in context: https://bugs.webkit.org/attachment.cgi?id=89412&action=review

> LayoutTests/fast/dom/navigator-detached-no-crash.html:55
> +    if (p != 'geolocation' && p != 'webkitGetUserMedia') { // Don't include Geolocation or the Media Stream API functions until most platforms have support.

Better to use early return, like:
  if (p == 'geolocation' || p == 'webkitGetUserMedia') //...
    continue;
  ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.