[Webkit-unassigned] [Bug 58139] Web Inspector: No headers information in network panel for downloads.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58139





--- Comment #7 from Vsevolod Vlasov <vsevik at chromium.org>  2011-04-13 11:36:36 PST ---
(In reply to comment #6)
> (From update of attachment 89277 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=89277&action=review
> 
> > Source/WebCore/loader/MainResourceLoader.cpp:261
> > +        InspectorInstrumentation::continueWithPolicyDownload(m_frame.get(), documentLoader(), identifier(), r);
> 
> Shouldn't we move this call a few lines down, closer to frameLoader()->client()->download call? Otherwise we call continueWithPolicyDownload while the loader reports an error.

That's right, I have checked that it's enough to call it 3 lines later to correctly show downloads in inspector.

FYI: PolicyDownload is used for downloads in Safari.
In Chromium we use PolicyIgnore.
That's the reason to make two calls to InspectorInstrumentation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.