[Webkit-unassigned] [Bug 58016] [EFL] Memory cache API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58016





--- Comment #9 from Grzegorz <g.czajkowski at samsung.com>  2011-04-13 06:24:33 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 89181 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=89181&action=review
> > 
> > >> Source/WebKit/efl/ewk/ewk_settings.cpp:355
> > >> +    EINA_SAFETY_ON_NULL_RETURN_VAL(cache, EINA_FALSE);
> > > 
> > > don't bother checking by NULL here. If it was NULL, it would not get to this point.
> > 
> > Could explain why we don't need to check NULL here, please?
> > Method memoryCache() is a singleton. It returns a pointer to the instance of WebCore's cache.
> > We can't trust what a pointer this method will return.
> 
> I'm saying that the only reason this pointer could be NULL is if there was an out-of-memory condition. In that scenario, WebCore would failed to load before this function could ever be called.
> 
Yes, I agree with you. But there is possibility to get the cache for instance in ewk function and to set the pointer on NULL, right? I know it's stupid but we can't exclude that case.
> But I'm really nitpicking here and this is not so important.
It's ok :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.