[Webkit-unassigned] [Bug 58333] [GTK] arguments passed to build-jsc are not taken into account

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58333





--- Comment #15 from Philippe Normand <pnormand at igalia.com>  2011-04-13 05:56:18 PST ---
(In reply to comment #14)
> Hello,
> 
> (In reply to comment #11)
> > (From update of attachment 89218 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=89218&action=review
> > 
> > > Tools/Scripts/build-jsc:71
> > > +    $result = buildGtkProject("JavaScriptCore", 0, @ARGV);
> > 
> > Probably should remove --gtk from that args first, like Qt does just below.
> > 
> > checkForArgumentAndRemoveFromARGV("--gtk");
> 
> 

I assume you tested this with a clean/full build?
That change looks good. Having a --help option in build-jsc would be nice too but i guess this could be part of another patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.