[Webkit-unassigned] [Bug 58006] Images with percentage based height/max-height are missing when they are inside blocks inside tables
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 12 23:06:41 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=58006
--- Comment #7 from Adele Peterson <adele at apple.com> 2011-04-12 23:06:41 PST ---
Now I'm thinking that the reason RenderTableSection's cell children flex code doesn't run is that percentHeightDescendants doesn't ever include this image element.
In http://trac.webkit.org/changeset/36513, Dan wrote this comment about code in RenderBox that adds to that list:
(WebCore::RenderBox::calcReplacedHeightUsing): Changed to skip over
anonymous containing blocks, if any, and when that happens, use
addPercentHeightDescendant() to ensure that the non-anonymous block
is aware of the dependent percent-height box.
In this case, because the containing block is never an anonymous block, we never add the image element to any RenderBox's list. I tried an experiment in RenderBox::computeReplacedLogicalHeightUsing to change that loop to a do while loop so the first containing block calls addPercentHeightDescendant even if its not an anonymous block. Again, this experiment fixed the original problem -- and broke the last test case in my attachment horribly. So maybe I'm off in the weeds here.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list