[Webkit-unassigned] [Bug 58403] Rename onEndChain and make it a static method.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 17:46:28 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58403


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89316|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2011-04-12 17:46:28 PST ---
(From update of attachment 89316)
View in context: https://bugs.webkit.org/attachment.cgi?id=89316&action=review

Otherwise LGTM.  If you're a committer, you can just add the two keywords when you land, otherwise you'll need to post a new patch.  Thanks!

> Source/WebCore/rendering/InlineFlowBox.cpp:255
> +bool isLastChildForRenderer(RenderObject* ancestor, RenderObject* child)

Should mark it static and possibly inline.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list