[Webkit-unassigned] [Bug 58122] chromium rebaseline script did the wrong thing with snowleopard expectations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58122





--- Comment #5 from James Kozianski <koz at chromium.org>  2011-04-12 17:10:43 PST ---
In theory the new rebaseline tool would handle this case correctly. Results from a chromium-snow-leopard bot wouldn't make it into the chromium-mac directory unless all the children of chromium-mac had equal results in them.

The algorithm that the new tool uses is

1. Construct a tree out of all the baseline search paths for all the ports
2. Retrieve new baselines for the given platforms and insert them into this in-memory tree in the port-specific result directory
3. Dedupe

So if I understand correctly [1] this case should work.


[1] As I understand it

* The chromium-mac directory had results X in it
* The chromium-mac-leopard directory had no results in it (thus inheriting chromium-mac results)
* chromium-mac-leopard and chromium-mac-snowleopard both fall back directly onto chromium-mac

We did a rebaseline for MAC, which caused new results for chromium-mac-snowleopard to get pulled down, and these were copied into chromium-mac, thus changing the results that chromium-mac-leopard inherited which was incorrect.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.