[Webkit-unassigned] [Bug 54634] media/video-controls-in-media-document.html has image+text diffs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54634


Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jer.noble at apple.com




--- Comment #33 from Jer Noble <jer.noble at apple.com>  2011-04-12 16:22:05 PST ---
(In reply to comment #32)
> As Eric S. guessed, CQ failure was legit.  Updated patch fixes that, by removing the bogus bottom padding from mediaControls{,Efl,QuickTime}.css.
> I say "bogus" b/c it makes the media experience difference in media documents and in <video>-using HTML, and because it makes difficult to reason about the rendered height of the media document (which can be relevant e.g. when using iframes).  This patch makes the media document case consistent with the non-media-document case.
> Hopefully it doesn't make a whole bunch of (unrelated) layouttests fail.

Avi, there isn't a Sources/WebCore/ChangeLog entry explaining the CSS changes.  Those changes are also unrelated to this bug, so if you feel they are necessary, please file a new bug to that effect, and make the CSS changes in that new bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.