[Webkit-unassigned] [Bug 55053] Implement non-activating clicks to allow dragging out of a background window

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55053





--- Comment #9 from Alexey Proskuryakov <ap at webkit.org>  2011-04-12 14:16:16 PST ---
(From update of attachment 89267)
View in context: https://bugs.webkit.org/attachment.cgi?id=89267&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:989
> +    if ([hitView isKindOfClass:[self class]]) {

Would it make sense to change this into an assertion?

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1011
> +    if ([hitView isKindOfClass:[self class]]) {

Ditto.

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:307
> +    process()->sendSync(Messages::WebPage::AcceptsFirstMouse(eventNumber, event), Messages::WebPage::AcceptsFirstMouse::Reply(result), m_pageID);

We probably need the usual 20 second timeout, or maybe even less than that - hardly anyone would wait 20 seconds to start dragging.

> Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:697
> +        result = hitResult.scrollbar() != 0;

We don't compare to 0, and if we must cast to boolean for some reason, it's usually "!!".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.