[Webkit-unassigned] [Bug 58374] New: WebKit2: Clients have to know not to call TranslateMessage() on key messages destined for WebKit2 web views

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 13:56:24 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58374

           Summary: WebKit2: Clients have to know not to call
                    TranslateMessage() on key messages destined for
                    WebKit2 web views
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows 7
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jeffm at apple.com


As described in bug 56020, Windows clients of WebKit2 have to know not to call TranslateMessage() on key messages destined for WebKit2 web views.  This is because WebKit2 handles messages asynchronously in the web process, and we don't want to call TranslateMessage() if the WM_KEYDOWN was actually handled by WebKit2 so things like pressing tab in the Web Inspector's console cycles through completion options (as opposed to inserting a tab because TranslateMessage() generates a WM_CHAR message from the WM_KEYDOWN).

If the client installs a WKPageUIClient, it's didNotHandleKeyEvent callback gets called in this case, but things like the Web Inspector typically won't have a WKPageUIClient installed.

The fact that clients have to know not to call TranslateMessage() seems prone to error, we should figure out a better solution to this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list