[Webkit-unassigned] [Bug 58016] [EFL] Memory cache API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 12:43:06 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58016





--- Comment #6 from Lucas De Marchi <demarchi at webkit.org>  2011-04-12 12:43:06 PST ---
(From update of attachment 89181)
View in context: https://bugs.webkit.org/attachment.cgi?id=89181&action=review

> Source/WebKit/efl/ewk/ewk_settings.cpp:349
> + * @param @c EINA_TRUE to enable cache of WebCore , @c EINA_FALSE to disable

@param set...

> Source/WebKit/efl/ewk/ewk_settings.cpp:355
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(cache, EINA_FALSE);

don't bother checking by NULL here. If it was NULL, it would not get to this point.

> Source/WebKit/efl/ewk/ewk_settings.cpp:375
> +    WebCore::MemoryCache* cache = WebCore::memoryCache();
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(cache, EINA_FALSE);

same here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list