[Webkit-unassigned] [Bug 58294] continue (3rd) experiment with moving caret by word in visual order

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58294





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2011-04-12 11:26:51 PST ---
(From update of attachment 89134)
View in context: https://bugs.webkit.org/attachment.cgi?id=89134&action=review

>>> Source/WebCore/editing/visible_units.cpp:1381
>>> +static VisiblePosition orderedLastWordBounaryInBox(const InlineBox* box, int offset, TextDirection blockDirection)
>> 
>> What does "ordered last word boundary" mean?
> 
> Needs comments here.
> 
> Word boundaries are visually ordered. It is ordered from right to left for LTR block, and ordered from left to right for RTL block. (as comments in nextWordBreakInBoxInsideBlockWithDifferentDirectionality and previousWordBreakInBoxInsideBlockWithSameDirectionality). 
> this returns the last word boundary in this ordered list.

Oh, in that case, I don't think you need include the word "ordered" at all. Just say lastVisualWordBoundaryInBox or visuallyLastWordBoundaryInBox.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.