[Webkit-unassigned] [Bug 58348] commit-queue should upload failure diffs when tests fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58348





--- Comment #5 from Eric Seidel <eric at webkit.org>  2011-04-12 11:21:45 PST ---
(From update of attachment 89226)
View in context: https://bugs.webkit.org/attachment.cgi?id=89226&action=review

>> Tools/Scripts/webkitpy/tool/commands/queues.py:263
>> +        bot_id = self._tool.status_server.bot_id or "bot"
> 
> self.name instead of "bot" ?

I guess.  it's not really a bot id.  But you could argue that file name should include commit-queue instead of id of the cq bot in question.  This currently matches what the flaky test reporting does.

>> Tools/Scripts/webkitpy/tool/commands/queues.py:270
>> +        comment_text = "The attached test failures were seen while running run-webkit-tests on the %s.\n" % (self.name)
> 
> No () needed.

True.  I don't know what pep8 says about this.  I generally include them for consistency.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.