[Webkit-unassigned] [Bug 58348] commit-queue should upload failure diffs when tests fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58348


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89226|review?                     |review+
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2011-04-12 10:52:50 PST ---
(From update of attachment 89226)
View in context: https://bugs.webkit.org/attachment.cgi?id=89226&action=review

> Tools/Scripts/webkitpy/tool/commands/queues.py:-54
> -

We probably should keep this line, right?

> Tools/Scripts/webkitpy/tool/commands/queues.py:263
> +        bot_id = self._tool.status_server.bot_id or "bot"

self.name instead of "bot" ?

> Tools/Scripts/webkitpy/tool/commands/queues.py:270
> +        comment_text = "The attached test failures were seen while running run-webkit-tests on the %s.\n" % (self.name)

No () needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.