[Webkit-unassigned] [Bug 58341] New: Improve media controls state management code by using CSS selectors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58341

           Summary: Improve media controls state management code by using
                    CSS selectors
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media Elements
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dglazkov at chromium.org
                CC: eric.carlson at apple.com, scherkus at chromium.org


Today, the code in media controls explicitly sets inline styles on specific controls to hide or show them. This can be completely eliminated if we instead manipulate state using DOM attributes. For example, if a network error occurs, we can set "disabled" attribute on the timeline control, and then specify in mediaControls.css:

video::-webkit-media-controls-timeline:disabled { display: none; }

Unfortunately, this is not immediately possible due to a restriction on how CSS selectors can be combined: the pseudo-element selector must always be the last one. Otherwise, the selector is deemed invalid.

Hyatt suggested that we relax this requirement, much the same way we relaxed it to allow scrollbar styling.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.