[Webkit-unassigned] [Bug 58324] Web Inspector: remove scriptWorldType from the protocol.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58324


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89212|review?                     |review+
               Flag|                            |




--- Comment #5 from Yury Semikhatsky <yurys at chromium.org>  2011-04-12 10:01:17 PST ---
(From update of attachment 89212)
View in context: https://bugs.webkit.org/attachment.cgi?id=89212&action=review

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:247
> +    return true;

return (currentWorld(exec) != mainThreadNormalWorld()); ?

> Source/WebCore/bindings/v8/DebuggerScript.js:80
> +        isContentScript: script.context_data && script.context_data.indexOf("injected") == 0

Please cast the expression to boolean explicitly to avoid surprises when it's an undefined and is casted ToBoolean() in ScriptDebugServer.cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.