[Webkit-unassigned] [Bug 57850] [Qt][WK2] Qt port needs test content for qwkhistory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57850


Jamie Cooley <james.cooley at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89216|                            |review?
               Flag|                            |




--- Comment #3 from Jamie Cooley <james.cooley at nokia.com>  2011-04-12 09:29:29 PST ---
Created an attachment (id=89216)
 --> (https://bugs.webkit.org/attachment.cgi?id=89216&action=review)
Proposed added QTestLib content for qwkhistory

Still have these style errors, but I'm not sure I can do anything about:

<snip> tst_qwkhistory.cpp:21:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]

Isn't actually in my code or any code that I can see or have touched. Must come from includes that include includes?

Source/WebKit2/UIProcess/API/qt/tests/qwkhistory/tst_qwkhistory.cpp:78:  historyFBTest_data is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]

This is QTestLib's data-driven test format... If I want to use data-driven (which is a pretty useful construct for this test), you have to name it as such.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.