[Webkit-unassigned] [Bug 58287] [chromium] WebCrossOriginRequestPolicy enum should use 'Web' prefix for values

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 12 09:18:57 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=58287


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89201|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-04-12 09:18:55 PST ---
(From update of attachment 89201)
R=me

Since this is likely to break Chromium, what is the plan for landing this change?

A couple ideas:

1- You could add a #define in WebURLLoader.h, and then in Chromium code you can land #ifdefs that switch on that #define to determine which definition of WebURLLoaderOptions and CrossOriginRequestPolicy to use.  Then, land that Chromium patch before landing this WebKit patch.

2- You could change this WebKit patch to make WebURLLoader.h #include WebURLLoaderOptions.h, and you could also keep the old enum around, defined in terms of the new one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list