[Webkit-unassigned] [Bug 56659] [GTK] Expose menu items and menus as children of a menu bar

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56659


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89015|review?                     |review+
               Flag|                            |




--- Comment #2 from chris fleizach <cfleizach at apple.com>  2011-04-12 08:50:44 PST ---
(From update of attachment 89015)
View in context: https://bugs.webkit.org/attachment.cgi?id=89015&action=review

otherwise looks good. r=me

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2968
>              return MenuItemRole;

It looks like we're calling parentObjectUnignored()->ariaRoleAttribute() potentially three times. I think that value should be stored local. parentObjectUnignored() can be little expensive.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.