[Webkit-unassigned] [Bug 58139] Web Inspector: No headers information in network panel for downloads.

Mon Apr 11 22:03:13 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=58139

Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #88827|review?                     |review-
               Flag|                            |

--- Comment #4 from Pavel Feldman <pfeldman at chromium.org>  2011-04-11 22:03:13 PST ---
(From update of attachment 88827)
View in context: https://bugs.webkit.org/attachment.cgi?id=88827&action=review

A couple of nits, otherwise looks good.

> LayoutTests/http/tests/inspector/network/download-expected.txt:1
> +http://127.0.0.1:8000/inspector/network/resources/download.zzz - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/inspector/network/resources/download.zzz, main document URL http://127.0.0.1:8000/inspector/network/download.html, http method GET> redirectResponse (null)

This looks platform specific.

> Source/WebCore/loader/MainResourceLoader.cpp:261
> +        InspectorInstrumentation::didReceiveResourceResponseButCanceled(m_frame.get(), documentLoader(), identifier(), r);

You should provide as much context into the signal as possible, in this case I would call it "continueWithPolicyDownload" or similar.

> Source/WebCore/loader/MainResourceLoader.cpp:274
> +        InspectorInstrumentation::didReceiveResourceResponseButCanceled(m_frame.get(), documentLoader(), identifier(), r);

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.