[Webkit-unassigned] [Bug 54181] Implement Page Visibility API.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54181





--- Comment #10 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-04-11 21:35:03 PST ---
(From update of attachment 84908)
View in context: https://bugs.webkit.org/attachment.cgi?id=84908&action=review

> Source/WebKit/chromium/public/WebView.h:366
> +#if defined(ENABLE_PAGE_VISIBILITY_API) && ENABLE_PAGE_VISIBILITY_API

we don't include #ifdefs like these in the public WebKit API headers.  instead, we always
include the feature in the headers.  the implementation, in WebViewImpl.cpp can be instead
conditionally compiled.

If you look at this method as an API that should stand on its own, it has a problem.  No
where do you define the set of allowed visibility states.  Are you sure the set of states
should be represented as a string in this API and not an enum?  If the possible set of 
values here is just visible or hidden, then perhaps this should just be made into a bool
setter.  In that case, I would also consider moving this down to WebWidget.  This is b/c
the same "is_hidden" flag is available in Chromium's RenderWidget class, which is a peer
to WebWidget.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.