[Webkit-unassigned] [Bug 53672] Modify make_names.pl to not include conditional includes unconditionally
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 11 20:31:18 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=53672
--- Comment #7 from Daniel Bates <dbates at webkit.org> 2011-04-11 20:31:18 PST ---
(From update of attachment 81051)
View in context: https://bugs.webkit.org/attachment.cgi?id=81051&action=review
>> Source/WebCore/dom/make_names.pl:625
>> + my $printJSElementIncludes = !!$wrapperFactoryType;
>
> It is necessary to explicitly convert $wrapperFactoryType to a boolean value (see my comment for line 656). Moreover, this variable is unnecessary since it's being referenced only once in this function; => the value should just be inlined into the if-statement.
*It is unnecessary to explicitly ...
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list