[Webkit-unassigned] [Bug 58287] WebCrossOriginRequestPolicy enum should use 'Web' prefix for values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58287





--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-04-11 20:30:53 PST ---
Hi Bill,

I didn't fully explain myself in the Chromium review.  There's actually a few conventions worth noting:

1- Top-level struct, class and enums each get their own header file in the WebKit API.
2- Sometimes a nested enum or struct is better if the enum/struct is scoped to being used by only a single interface.  Nested enums/structs are not prefixed with Web.
3- Enums are named like so:  enum Foo { FooBar, FooBaz };  <-- values prefixed by enum name

These are in addition to the convention about globals starting with the Web prefix.  I wish I had explained all of this so that it would save you time.

I only bother to point all of this out as it is nice to keep the WebKit API consistent style-wise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.