[Webkit-unassigned] [Bug 58280] SerializedScriptValue shouldn't always throw exceptions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58280


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2011-04-11 16:10:18 PST ---
Attachment 89113 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/loader/FrameLoader.h:42:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/bindings/js/SerializedScriptValue.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/bindings/js/SerializedScriptValue.h:54:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/js/SerializedScriptValue.h:54:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/js/SerializedScriptValue.h:54:  Missing spaces around =  [whitespace/operators] [4]
Source/WebCore/bindings/js/SerializedScriptValue.h:67:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/js/SerializedScriptValue.h:67:  The parameter name "globalObject" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/js/SerializedScriptValue.h:67:  Missing spaces around =  [whitespace/operators] [4]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1259:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1318:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1346:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1393:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1422:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1422:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1424:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1425:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1427:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1428:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1430:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1431:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/bindings/js/SerializedScriptValue.cpp:1434:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1239:  Missing space before ( in if(  [whitespace/parens] [5]
Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1240:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 25 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.