[Webkit-unassigned] [Bug 58248] [Qt] Better padding for inputs and comboxes in mobile theme

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58248


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89045|review?                     |review-
               Flag|                            |




--- Comment #4 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-04-11 13:23:55 PST ---
(From update of attachment 89045)
View in context: https://bugs.webkit.org/attachment.cgi?id=89045&action=review

> Source/WebCore/platform/qt/RenderThemeQt.cpp:109
> +static const float defaultButtonPaddingLeft = 18;

I am not sure the default is really needed here. We could also put them in an anomymous namespace so that they are only visible here.

Info here: http://msdn.microsoft.com/en-us/library/yct4x9k5(v=vs.80).aspx : You can declare an unnamed namespace as a superior alternative to the use of global static variable declarations.

> Source/WebCore/platform/qt/RenderThemeQt.cpp:113
> +static const float defaultComboBoxPadding = 9;

As it is the selector element, combobox might not be the best name

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.