[Webkit-unassigned] [Bug 57904] onClick does not function with <select> elements in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57904


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89021|review?                     |review+
               Flag|                            |




--- Comment #5 from Anders Carlsson <andersca at apple.com>  2011-04-11 12:57:07 PST ---
(From update of attachment 89021)
View in context: https://bugs.webkit.org/attachment.cgi?id=89021&action=review

The indentation in WebPopupMenuProxyMac.mm is messed up.

> Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:127
> +        if (m_client)

This could be an early return.

> Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:132
> +            NSEvent* initiatingNSEvent = m_client->currentlyProcessedMouseDownEvent()->nativeEvent();

I think you need to null check the event before getting the native event.

> Source/WebKit2/UIProcess/win/WebPopupMenuProxyWin.cpp:328
> +    if (m_client) {

Early return.

> Source/WebKit2/UIProcess/win/WebPopupMenuProxyWin.cpp:339
> +        const MSG* initiatingWinEvent = m_client->currentlyProcessedMouseDownEvent()->nativeEvent();

Null check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.